Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactoring: replace github.com/pkg/errors by standard errors #434

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RouxAntoine
Copy link

Like ask in #380
Here is the extraction of the commit to replacement of the external github.com/pkg/errors dependency by built in errors

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Dec 28, 2024
@RouxAntoine RouxAntoine force-pushed the feature/replace-pkg-errors-by-builtin-errors branch from bbc1b91 to 3199f03 Compare December 28, 2024 14:01
@RouxAntoine
Copy link
Author

I found that this have also be done in #421

@ahmetb
Copy link
Owner

ahmetb commented Dec 28, 2024

Do you mind replacing all commas with ":", that's the standard form.

kubernetes/release#2549

@RouxAntoine RouxAntoine force-pushed the feature/replace-pkg-errors-by-builtin-errors branch 2 times, most recently from e47bbe9 to 93a14bd Compare December 28, 2024 16:42
@RouxAntoine
Copy link
Author

RouxAntoine commented Dec 28, 2024

Do you mind replacing all commas with ":", that's the standard form.

kubernetes/release#2549

done,

I can also replace cmdutil.IsNotFoundErr by errors.Is like in PR #421 (edit, also done)

@RouxAntoine RouxAntoine force-pushed the feature/replace-pkg-errors-by-builtin-errors branch from 93a14bd to 33dd56a Compare December 28, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants