Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the setup new codes widget part of the code selection widget optional #646

Conversation

edan-bainglass
Copy link
Member

This PR provides a backwards compatible path to make the new code setup widget part of the code selection widget optional.

The PR also adds a flag (true by default) to control if the codes should be pre-fetched. This is useful, for example, in the QE app, where the MVC redesign (#802) provides these codes via models, removing the responsibility from the UI widgets.

Copy link

codecov bot commented Dec 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.46%. Comparing base (2677368) to head (491b483).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #646      +/-   ##
==========================================
+ Coverage   83.43%   83.46%   +0.02%     
==========================================
  Files          17       17              
  Lines        3550     3556       +6     
==========================================
+ Hits         2962     2968       +6     
  Misses        588      588              
Flag Coverage Δ
python-3.11 83.46% <100.00%> (+0.02%) ⬆️
python-3.9 83.50% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edan-bainglass edan-bainglass force-pushed the optional-computational-resources branch from 0266afc to 3d1492f Compare December 8, 2024 12:34
Copy link
Member

@superstar54 superstar54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work!
Could you also add a test on the new optional parameters?

@edan-bainglass edan-bainglass force-pushed the optional-computational-resources branch from 3d1492f to df4e23f Compare December 9, 2024 11:10
Copy link
Contributor

@danielhollas danielhollas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've had only a very brief look and don't see anything unreasonable, thanks!

@edan-bainglass edan-bainglass force-pushed the optional-computational-resources branch from df4e23f to 491b483 Compare December 9, 2024 11:28
@superstar54 superstar54 self-requested a review December 9, 2024 11:29
Copy link
Member

@superstar54 superstar54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the tests!

@edan-bainglass edan-bainglass merged commit fd8c1b0 into aiidalab:master Dec 9, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants