-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the setup new codes widget part of the code selection widget optional #646
Make the setup new codes widget part of the code selection widget optional #646
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #646 +/- ##
==========================================
+ Coverage 83.43% 83.46% +0.02%
==========================================
Files 17 17
Lines 3550 3556 +6
==========================================
+ Hits 2962 2968 +6
Misses 588 588
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
0266afc
to
3d1492f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work!
Could you also add a test on the new optional parameters?
3d1492f
to
df4e23f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've had only a very brief look and don't see anything unreasonable, thanks!
df4e23f
to
491b483
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the tests!
This PR provides a backwards compatible path to make the new code setup widget part of the code selection widget optional.
The PR also adds a flag (true by default) to control if the codes should be pre-fetched. This is useful, for example, in the QE app, where the MVC redesign (#802) provides these codes via models, removing the responsibility from the UI widgets.