Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependencies #1246

Merged
merged 4 commits into from
Jan 6, 2025
Merged

Conversation

jakob-keller
Copy link
Collaborator

Description of Change

Add missing runtime and dev dependencies.

Assumptions

All direct dependencies (i.e. used by codebase) should be specified as such.

Checklist for All Submissions

  • I have added change info to CHANGES.rst
  • If this is resolving an issue (needed so future developers can determine if change is still necessary and under what conditions) (can be provided via link to issue with these details):
    • Detailed description of issue
    • Alternative methods considered (if any)
    • How issue is being resolved
    • How issue can be reproduced
  • If this is providing a new feature (can be provided via link to issue with these details):
    • Detailed description of new feature
    • Why needed
    • Alternatives methods considered (if any)

Checklist when updating botocore and/or aiohttp versions

  • I have read and followed CONTRIBUTING.rst
  • I have updated test_patches.py where/if appropriate (also check if no changes necessary)
  • I have ensured that the awscli/boto3 versions match the updated botocore version

@jakob-keller jakob-keller added the dependencies Pull requests that update a dependency file label Dec 29, 2024
@jakob-keller jakob-keller self-assigned this Dec 29, 2024
Copy link

codecov bot commented Dec 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.00%. Comparing base (9647083) to head (466b62a).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1246      +/-   ##
==========================================
+ Coverage   87.99%   88.00%   +0.01%     
==========================================
  Files          67       67              
  Lines        5904     5904              
==========================================
+ Hits         5195     5196       +1     
+ Misses        709      708       -1     
Flag Coverage Δ
unittests 88.00% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

requirements-dev.in Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@jakob-keller
Copy link
Collaborator Author

Maybe we should also update the Requirements section in README. Is that even necessary? It feels a bit redundant to me.

pyproject.toml Outdated Show resolved Hide resolved
requirements-dev.in Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@jakob-keller jakob-keller enabled auto-merge January 6, 2025 20:07
@jakob-keller jakob-keller added this pull request to the merge queue Jan 6, 2025
Merged via the queue into aio-libs:master with commit 095edc8 Jan 6, 2025
11 checks passed
@jakob-keller jakob-keller deleted the fix-dependencies branch January 6, 2025 21:40
@jakob-keller jakob-keller mentioned this pull request Jan 7, 2025
13 tasks
@thehesiod
Copy link
Collaborator

I really appreciate all the work going on but:

  1. please do not merge w/o approval especially when requesting approval
  2. please do not resolve discussions that you did not start

I've updated the branch settings to codify these requests. We've been playing too fast and loose with master reviews

@jakob-keller
Copy link
Collaborator Author

I really appreciate all the work going on but:

  1. please do not merge w/o approval especially when requesting approval
  2. please do not resolve discussions that you did not start

I've updated the branch settings to codify these requests. We've been playing too fast and loose with master reviews

Gotcha and apologies for my impatience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants