-
-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dependencies #1246
Fix dependencies #1246
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1246 +/- ##
==========================================
+ Coverage 87.99% 88.00% +0.01%
==========================================
Files 67 67
Lines 5904 5904
==========================================
+ Hits 5195 5196 +1
+ Misses 709 708 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Maybe we should also update the |
a466e60
to
1397f15
Compare
1397f15
to
10a2fbd
Compare
10a2fbd
to
466b62a
Compare
I really appreciate all the work going on but:
I've updated the branch settings to codify these requests. We've been playing too fast and loose with master reviews |
Gotcha and apologies for my impatience. |
Description of Change
Add missing runtime and dev dependencies.
Assumptions
All direct dependencies (i.e. used by codebase) should be specified as such.
Checklist for All Submissions
Checklist when updating botocore and/or aiohttp versions