Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 3.8 support as it has reached EOL #1036

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Dec 1, 2024

No description provided.

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Dec 1, 2024
@bdraco bdraco marked this pull request as ready for review December 1, 2024 15:14
@bdraco
Copy link
Member Author

bdraco commented Dec 1, 2024

Looks like the linter has been failing since 2dc89df

Copy link

codspeed-hq bot commented Dec 1, 2024

CodSpeed Performance Report

Merging #1036 will degrade performances by 19.27%

Comparing drop_py38 (112e14a) with master (fbf28ae)

Summary

❌ 1 (👁 1) regressions
✅ 37 untouched benchmarks

Benchmarks breakdown

Benchmark master drop_py38 Change
👁 test_cimultidict_extend_istr 128.1 µs 158.7 µs -19.27%

.pre-commit-config.yaml Outdated Show resolved Hide resolved
.pre-commit-config.yaml Outdated Show resolved Hide resolved
.pre-commit-config.yaml Outdated Show resolved Hide resolved
.pre-commit-config.yaml Outdated Show resolved Hide resolved
bdraco and others added 4 commits December 3, 2024 10:23
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants