BUG: fix JSONC support #1426
Merged
BUG: fix JSONC support #1426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI isn't happy although I'm struggling to decipher the error messages. |
HaoZeke
approved these changes
Aug 14, 2024
|
I want to say the CI failure looks unrelated? |
|
It is odd, especially since it isn't surprising at all that the extension (a C-Python extension) will fail on PyPy.. I'd have thought it wouldn't even try to build it there.. |
|
TL;DR: Please pin setuptools to a known good version and only update it after checking that it works. This was reported as pypy/pypy#5004 and is due to a new setuptools release, which vendors pypa/distutils, which started requiring a default sysconfig value that PyPy did not supply pypa/distutils#280. |
|
CI is happy after pinning setuptools in this PR. This should be good to go. |
|
Thanks @lucascolley and @mattip |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@HaoZeke I think this should be it! close gh-1425