Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add transparent background #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add transparent background #20

wants to merge 1 commit into from

Conversation

witrin
Copy link
Contributor

@witrin witrin commented May 17, 2016 •
edited
Loading

Remove the background polygon from Graphviz and replaces rsvg-convert with convert.

@witrin witrin changed the title Add transparent background to PNG output Add transparent background May 17, 2016
@witrin
Copy link
Contributor Author

witrin commented May 18, 2016

The replacement with Imagemagick's convert was just a quick move because rsvg-convert doesn't have rendered the background transparent, but maybe this was a installation problem on my server (2.40.13).

@witrin
Copy link
Contributor Author

witrin commented Nov 26, 2016

@aivarsk Would you be so kind a leave a comment?

@aivarsk
Copy link
Owner

aivarsk commented Nov 29, 2016

Well, I don't spend much time thinking about this as I use plantuml for my own UML needs.
Adding transparent background is ok but I don't like/understand why you removed the main function from scruffy.py. It puzzles me as one of use cases for me was running scruffy.py on different svg files.
So if you make a pull request the background only I would pull it. And the removal of main() is separate topic/pull request that has to be discussed.

@witrin
Copy link
Contributor Author

witrin commented Nov 30, 2016

Alright, thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@witrin @aivarsk