Skip to content

Commit

Permalink
refactor: Move test_account crate to the /tests dir (matter-labs#918)
Browse files Browse the repository at this point in the history
## What ❔

- Moves `test_account` crate to the `/tests` instead of `/lib`
- Marks is as `publish = false` in Cargo.toml.

## Why ❔

- It's a test-only dep, so it makes more sense there.
- We're going to publish everything in `/lib` soon-ish, so if it'll be
there unpublished, it may be confusing.

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [ ] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ ] Tests for the changes have been added / updated.
- [ ] Documentation comments have been added / updated.
- [ ] Code has been formatted via `zk fmt` and `zk lint`.
- [ ] Spellcheck has been run via `zk spellcheck`.
  • Loading branch information
popzxc authored Jan 23, 2024
1 parent c260850 commit bce8604
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 8 deletions.
2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,9 @@ members = [
"core/lib/vlog",
"core/lib/multivm",
"core/lib/web3_decl",
"core/lib/test_account",

# Test infrastructure
"core/tests/test_account",
"core/tests/cross_external_nodes_checker",
"core/tests/loadnext",
"core/tests/vm-benchmark",
Expand Down
2 changes: 1 addition & 1 deletion core/lib/multivm/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,6 @@ vise = { git = "https://github.com/matter-labs/vise.git", version = "0.1.0", rev

[dev-dependencies]
tokio = { version = "1", features = ["time"] }
zksync_test_account = { path = "../test_account" }
zksync_test_account = { path = "../../tests/test_account" }
ethabi = "18.0.0"
zksync_eth_signer = { path = "../eth_signer" }
2 changes: 1 addition & 1 deletion core/lib/zksync_core/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ actix-web = "4.0.0-beta.8"
tracing = "0.1.26"

[dev-dependencies]
zksync_test_account = { path = "../test_account" }
zksync_test_account = { path = "../../tests/test_account" }

assert_matches = "1.5"
jsonrpsee = "0.21.0"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,14 @@ license = "MIT OR Apache-2.0"
keywords = ["blockchain", "zksync"]
categories = ["cryptography"]
readme = "README.md"
publish = false

[dependencies]
zksync_types = { path = "../types" }
zksync_system_constants = { path = "../constants" }
zksync_utils = { path = "../utils" }
zksync_eth_signer = { path = "../eth_signer" }
zksync_contracts = { path = "../contracts" }
zksync_types = { path = "../../lib/types" }
zksync_system_constants = { path = "../../lib/constants" }
zksync_utils = { path = "../../lib/utils" }
zksync_eth_signer = { path = "../../lib/eth_signer" }
zksync_contracts = { path = "../../lib/contracts" }

hex = "0.4"
ethabi = "18.0.0"
File renamed without changes.

0 comments on commit bce8604

Please sign in to comment.