Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add openshift/rosa to tools #1127

Merged
merged 1 commit into from
Nov 5, 2024
Merged

feat: add openshift/rosa to tools #1127

merged 1 commit into from
Nov 5, 2024

Conversation

rgee0
Copy link
Contributor

@rgee0 rgee0 commented Oct 26, 2024

Description

Adds the rosa command line tool that simplifies the use of Red Hat OpenShift Service on AWS, also known as ROSA

Motivation and Context

How Has This Been Tested?

###Functional

➜  arkade git:(rosa) ✗ ./arkade get rosa                                                
Downloading: rosa
2024/10/26 09:21:42 Looking up version for rosa
2024/10/26 09:21:42 Found: v1.2.46
Downloading: https://github.com/openshift/rosa/releases/download/v1.2.46/rosa_Darwin_arm64.tar.gz
15.38 MiB / 15.38 MiB [------------------------------------------------------------------] 100.00%
/var/folders/22/3b_f27kj3s37lbfqz_fq44jw0000gp/T/arkade-3130711499/rosa_Darwin_arm64.tar.gz written.
2024/10/26 09:21:44 Extracted: /var/folders/22/3b_f27kj3s37lbfqz_fq44jw0000gp/T/arkade-3130711499/rosa
2024/10/26 09:21:44 Copying /var/folders/22/3b_f27kj3s37lbfqz_fq44jw0000gp/T/arkade-3130711499/rosa to /Users/rgee0/.arkade/bin/rosa

Wrote: /Users/rgee0/.arkade/bin/rosa (64.82MB)

# Add arkade binary directory to your PATH variable
export PATH=$PATH:$HOME/.arkade/bin/

# Test the binary:
/Users/rgee0/.arkade/bin/rosa

# Or install with:
sudo mv /Users/rgee0/.arkade/bin/rosa /usr/local/bin/

👏 Say thanks for arkade and sponsor Alex via GitHub: https://github.com/sponsors/alexellis

make e2e

➜  arkade git:(rosa) make e2e
CGO_ENABLED=0 go test github.com/alexellis/arkade/pkg/get -cover --tags e2e -v
...
PASS
coverage: 61.6% of statements
ok  	github.com/alexellis/arkade/pkg/get	10.624s	coverage: 61.6% of statements

test_tool

➜  arkade git:(rosa) ✗ ./hack/test-tool.sh rosa
+ ./arkade get rosa --arch arm64 --os darwin --quiet
+ file /Users/rgee0/.arkade/bin/rosa
/Users/rgee0/.arkade/bin/rosa: Mach-O 64-bit executable arm64
+ rm /Users/rgee0/.arkade/bin/rosa
+ echo

+ ./arkade get rosa --arch x86_64 --os darwin --quiet
+ file /Users/rgee0/.arkade/bin/rosa
/Users/rgee0/.arkade/bin/rosa: Mach-O 64-bit executable x86_64
+ rm /Users/rgee0/.arkade/bin/rosa
+ echo

+ ./arkade get rosa --arch x86_64 --os linux --quiet
+ file /Users/rgee0/.arkade/bin/rosa
/Users/rgee0/.arkade/bin/rosa: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), statically linked, Go BuildID=E8sLxYx_-ZHSVoeu8gL-/9jkfgOtOByb35MkJHI5u/fPx_hdZ_WSKVLbwQiWrz/yWcw5iJAIuJtGyAPu3QK, stripped
+ rm /Users/rgee0/.arkade/bin/rosa
+ echo

+ ./arkade get rosa --arch aarch64 --os linux --quiet
+ file /Users/rgee0/.arkade/bin/rosa
/Users/rgee0/.arkade/bin/rosa: ELF 64-bit LSB executable, ARM aarch64, version 1 (SYSV), statically linked, Go BuildID=3qG8_22qCrjQlBdeLOrb/KjE8ijakXdX5XShYrgFr/csdQTaEyFi_g6J8p3e-7/Ret3jQ5k_pvnsbOJhLNj, stripped
+ rm /Users/rgee0/.arkade/bin/rosa
+ echo

+ ./arkade get rosa --arch x86_64 --os mingw --quiet
+ file /Users/rgee0/.arkade/bin/rosa.exe
/Users/rgee0/.arkade/bin/rosa.exe: PE32+ executable (console) x86-64, for MS Windows
+ rm /Users/rgee0/.arkade/bin/rosa.exe
+ echo

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Documentation

  • I have updated the list of tools in README.md if (required) with ./arkade get --format markdown
  • I have updated the list of apps in README.md if (required) with ./arkade install --help

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have tested this on arm, or have added code to prevent deployment

@alexellis alexellis merged commit 3595b71 into alexellis:master Nov 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Red Hat OpenShift on AWS cli as a tool
2 participants