Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mitigate effect on tags of semVer #1129

Closed
wants to merge 1 commit into from

Conversation

rgee0
Copy link
Contributor

@rgee0 rgee0 commented Oct 30, 2024

Description

Motivation and Context

  • I have raised an issue to propose this change, which has been given a label of design/approved by a maintainer (required)

How Has This Been Tested?

If updating or adding a new CLI to arkade get, run:

go build && ./hack/test-tool.sh TOOL_NAME

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Documentation

  • I have updated the list of tools in README.md if (required) with ./arkade get --format markdown
  • I have updated the list of apps in README.md if (required) with ./arkade install --help

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have tested this on arm, or have added code to prevent deployment

a chart upgrade which contained postgres:16 highlighted that the current appraoch to parsing tags meant that 16 moved to 17.0.0 which doesnt exist. We can alleviate this by using .Original() from semVer once the most recent tag has been found.  Using this also removes the need to manipulate the resulting string in the event of the image using a leading v

Signed-off-by: Richard Gee <[email protected]>
@rgee0 rgee0 changed the title Pg versions fix: mitigate effect on tags of semVer Oct 30, 2024
@rgee0 rgee0 closed this Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant