-
-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add kube-linter tool #948
Conversation
Thanks for the PR. @Jasstkn could you review please? |
pkg/get/get_test.go
Outdated
}, | ||
{ | ||
os: "linux", | ||
arch: archARM64, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like kube-linter
doesn't support ARM at all, therefore this test is redundant.
I think that we need to hardcode the arch64 as the only supported architecture in the template and remove the redundant test. @alexellis what are your thoughts here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right I will remove it ;)
@tvcsantos can I also ask you to update your branch from master? |
Will do that. Ty |
Thank you for your contribution. unfortunately, one or more of your commits are missing the required "Signed-off-by:" statement. Signing off is part of the Developer Certificate of Origin (DCO) which is used by this project. Read the DCO and project contributing guide carefully, and amend your commits using the git CLI. Note that this does not require any cryptography, keys or special steps to be taken. 💡 Shall we fix this?This will only take a few moments. First, clone your fork and checkout this branch using the git CLI. Next, set up your real name and email address:
Finally, run one of these commands to add the "Signed-off-by" line to your commits. If you only have one commit so far then run: Check that the message has been added properly by running "git log". |
7489e12
to
1abba21
Compare
All done. If you need something extra ping :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
@tvcsantos just need a rebase on the README file now, thanks. |
Thank you for your contribution. unfortunately, one or more of your commits are missing the required "Signed-off-by:" statement. Signing off is part of the Developer Certificate of Origin (DCO) which is used by this project. Read the DCO and project contributing guide carefully, and amend your commits using the git CLI. Note that this does not require any cryptography, keys or special steps to be taken. 💡 Shall we fix this?This will only take a few moments. First, clone your fork and checkout this branch using the git CLI. Next, set up your real name and email address:
Finally, run one of these commands to add the "Signed-off-by" line to your commits. If you only have one commit so far then run: Check that the message has been added properly by running "git log". |
Done ;) |
2eac035
to
4fef3e8
Compare
4fef3e8
to
1abba21
Compare
okay not done. I will do it in a bit :D. Having some troubles with the signoff :D |
Now all good :). If you need something ping me 👍 |
Looks like we have 6x commits now, so if you follow my video it will walk you through how to squash them all down: https://www.youtube.com/watch?v=8j0H6urZ-bU But before you do that, rebase master with
|
Signed-off-by: Tiago Santos <[email protected]>
b93e438
to
e99d379
Compare
Okay I got it you only want one commit. Done ;) sorry for the delay |
Thanks Tiago. Looking forward to your next PR. |
Description
This PR adds kube-linter cli tool to arkade. KubeLinter is a static analysis tool that checks Kubernetes YAML files and Helm charts to ensure the applications represented in them adhere to best practices.
Motivation and Context
design/approved
by a maintainer (required)I would be nice to have kube-linter cli tool included on arkade. KubeLinter is a static analysis tool that checks Kubernetes YAML files and Helm charts to ensure the applications represented in them adhere to best practices.
How Has This Been Tested?
Added tests to
get_test.go
and also run./hack/test-tool.sh kube-linter
.If updating or adding a new CLI to
arkade get
, run:Logs attached below:
arkade_kube_linter.log
Types of changes
Documentation
./arkade get --format markdown
./arkade install --help
Checklist:
git commit -s