Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix modal with Bootstrap 5 #126

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Haititi
Copy link

@Haititi Haititi commented Oct 1, 2022

The <div class="fm-modal"> you are injecting is missing the bootstrap 5 class modal, so it should become:
<div class="modal fm-modal">.

Can you please merge this pull request? your file-manager is not usable as it is for the moment.
Please also update https://github.com/alexusmai/laravel-file-manager !
Thanks a lot!

With Bootstrap 5, the "fm-modal" div should also use the class "modal" in order to work correctly.
@Haititi
Copy link
Author

Haititi commented Mar 5, 2023

@alexusmai can you please merge this PR to fix your modals?
None of your modals are usable without this fix.
Thanks in advance.

@siebsie23
Copy link
Contributor

Please merge this! For me the modals are completely broken without the modal tag.

@siebsie23
Copy link
Contributor

Just tested, the modal is not visible when opened. You should add !important tags to the display:block and position:absolute css selectors like I did in my fork: https://github.com/siebsie23/vue-laravel-file-manager/blob/master/src/components/modals/ModalBlock.vue

@alexusmai
Copy link
Owner

I don’t understand why add this class, it will be overwritten by the existing one.
And modal windows are displayed normally..

screen 1

screen 2

@siebsie23
Copy link
Contributor

For me it doesn't load the CSS variables because they are loaded with the .modal selector.

@siebsie23
Copy link
Contributor

@alexusmai Can I open a new PR that also adds the !important tags I mentioned which fixes my and @Haititi 's issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants