fix(analytical): Fix Louvain algorithm's stop condition

alibaba · Dec 25, 2024 · 5d0051a · 5d0051a
1 parent 9699556
commit 5d0051a
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/analytical_engine/apps/pregel/louvain/louvain_app_base.h b/analytical_engine/apps/pregel/louvain/louvain_app_base.h
@@ -226,8 +226,7 @@ class LouvainAppBase
       // after one pass if already decided halt, that means the pass yield no
       // changes, so we halt computation.
       if (current_super_step <= 14 ||
-          std::fabs(actual_quality - ctx.prev_quality()) <
-              min_quality_improvement) {
+          (actual_quality - ctx.prev_quality()) <= min_quality_improvement) {
         // turn to sync community result
         ctx.compute_context().set_superstep(sync_result_step);
         syncCommunity(frag, ctx, messages);