feat: support to process tag #1806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abingcbc
changed the title
henryzhx8
requested changes
Oct 21, 2024
There was a problem hiding this comment.
- 整体实现需要重新看一下文档
- 这个插件应该是pipeline级别的了
- C++和Go串联的情况下，应该全部由C++这边来完成处理，Go应该啥都不做，只有Aggregator的Topic是个例外
Abingcbc
force-pushed
the
process_tag
branch
3 times, most recently
from
062c0d2 to
05d5f38
Compare
messixukejia
requested changes
Jan 13, 2025
henryzhx8
requested changes
Jan 13, 2025
There was a problem hiding this comment.
现有C++和go的tag行为不一致，需要保持一致，而不是继续遵从现状，详见设计文档。
henryzhx8
requested changes
Jan 16, 2025
pluginmanager/processor_tag.go
Outdated
| ) | ||
|
|
||
| const ( | ||
| hostNameDefaultTagKey = "host_name" |
There was a problem hiding this comment.
这里只有开源的，商业版在另一个文件，单独提交到内部
henryzhx8
requested changes
Jan 21, 2025
core/file_server/ContainerInfo.cpp
Outdated
Comment on lines
109
to
115
| std::string key = tags[i - 1].asString(); | ||
| std::string value = tags[i].asString(); | ||
| // 老版本或者容器元信息 | ||
| if (isOldCheckpoint && containerNameTag.find(key) != containerNameTag.end()) { | ||
| containerInfo.AddMetadata(key, value); | ||
| } else { | ||
| containerInfo.mTags.emplace_back(tag); | ||
| containerInfo.mTags.emplace_back(key, value); |
There was a problem hiding this comment.
这段逻辑和qiuwencheng确认下，感觉有点怪
messixukejia
approved these changes
Jan 21, 2025
henryzhx8
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
支持重命名和修改Tag
配置
内部数据结构定义调整