Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #12946] Improve Clarity and Log Level of Shutdown Message in HttpClientBeanHolder #12950

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

SoilChang
Copy link

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

This change improves the clarity and professionalism of logging messages across various components. Specifically, it updates log messages related to resource destruction processes to ensure consistent grammar, clarity, and message intent.

Brief changelog

Updated log messages in ConfigHttpClientManager to clarify resource destruction stages.
Updated log messages in NamingHttpClientManager for better grammar and meaning.
Refined log messages in ThreadPoolManager to ensure clarity about the shutdown process.
Improved log messages in HttpClientBeanHolder to clearly describe the start and completion of HTTP client destruction.
Enhanced logging in NotifyCenter to make resource cleanup messages more professional and meaningful.
Updated HttpClientManager in the config and naming modules to use consistent and clear log messages during the destruction of HTTP clients.

Verifying this change

visual verifying

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@CLAassistant
Copy link

CLAassistant commented Dec 16, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

Thanks for your this PR. 🙏
Please check again for your PR changes whether contains any usage/api/configuration change such as Add new API , Add new configuration, Change default value of configuration.
If so, please add or update documents(markdown type) in docs/next/ for repository nacos-group/nacos-group.github.io


感谢您提交的PR。 🙏
请再次查看您的PR内容,确认是否包含任何使用方式/API/配置参数的变更,如:新增API新增配置参数修改默认配置等操作。
如果是,请确保在提交之前,在仓库nacos-group/nacos-group.github.io中的docs/next/目录下添加或更新文档(markdown格式)。

@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.

Project coverage is 72.27%. Comparing base (14becb8) to head (acfec86).

Files with missing lines Patch % Lines
...onfig/server/service/notify/HttpClientManager.java 50.00% 1 Missing ⚠️
...m/alibaba/nacos/naming/misc/HttpClientManager.java 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #12950      +/-   ##
=============================================
- Coverage      72.28%   72.27%   -0.01%     
+ Complexity     10000     9999       -1     
=============================================
  Files           1309     1309              
  Lines          41991    41991              
  Branches        4405     4405              
=============================================
- Hits           30355    30351       -4     
- Misses          9512     9516       +4     
  Partials        2124     2124              
Files with missing lines Coverage Δ
...os/client/config/impl/ConfigHttpClientManager.java 54.54% <100.00%> (ø)
...nt/naming/remote/http/NamingHttpClientManager.java 95.23% <100.00%> (ø)
...ibaba/nacos/common/executor/ThreadPoolManager.java 100.00% <100.00%> (ø)
...libaba/nacos/common/http/HttpClientBeanHolder.java 79.31% <100.00%> (ø)
.../com/alibaba/nacos/common/notify/NotifyCenter.java 90.15% <100.00%> (ø)
...onfig/server/service/notify/HttpClientManager.java 74.07% <50.00%> (-7.41%) ⬇️
...m/alibaba/nacos/naming/misc/HttpClientManager.java 50.00% <50.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14becb8...acfec86. Read the comment docs.

@SoilChang
Copy link
Author

i will check the open source agreement and get back to you soon

@KomachiSion KomachiSion added this to the 2.5.0 milestone Jan 2, 2025
@KomachiSion KomachiSion added area/Client Related to Nacos Client SDK kind/enhancement Category issues or prs related to enhancement. labels Jan 2, 2025
@KomachiSion
Copy link
Collaborator

The Pr can't be merged because cla can't pass.

The commit is from CharlesChangOkx, but PR is from SoilChang

@SoilChang
Copy link
Author

sorry ya i use company laptop to commit it, which give rise to a lot of issue. im still asking my company if i can sign those contribution agreements. i don't think it will get resolved soon. i think i will just my own laptop and do this contribution on my own time so speed up the progress.

@wuyfee
Copy link

wuyfee commented Jan 2, 2025

$\color{green}{SUCCESS}$
DETAILS
✅ - docker: success
✅ - deploy (standalone & cluster & standalone_auth): success
✅ - e2e-java-test (standalone & cluster & standalone_auth): success
✅ - e2e-go-test (standalone & cluster): success
✅ - e2e-cpp-test (standalone & cluster): success
✅ - e2e-csharp-test (standalone & cluster): success
✅ - e2e-nodejs-test (standalone & cluster): success
✅ - e2e-python-test (standalone & cluster): success
✅ - clean (standalone & cluster & standalone_auth): success

@SoilChang SoilChang force-pushed the develop-improve-log-message-and-level branch 2 times, most recently from f09980f to 90a118a Compare January 2, 2025 15:09
@SoilChang SoilChang force-pushed the develop-improve-log-message-and-level branch from 90a118a to acfec86 Compare January 2, 2025 15:12
@SoilChang
Copy link
Author

i have updated the MR from my own laptop.

@SoilChang
Copy link
Author

i see that it says the open-source contribution agreements have been signed. I think this is ready for merge. Please let me know if there are any other blockers. thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/Client Related to Nacos Client SDK kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants