-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #12946] Improve Clarity and Log Level of Shutdown Message in HttpClientBeanHolder #12950
base: develop
Are you sure you want to change the base?
[ISSUE #12946] Improve Clarity and Log Level of Shutdown Message in HttpClientBeanHolder #12950
Conversation
Thanks for your this PR. 🙏 感谢您提交的PR。 🙏 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #12950 +/- ##
=============================================
- Coverage 72.28% 72.27% -0.01%
+ Complexity 10000 9999 -1
=============================================
Files 1309 1309
Lines 41991 41991
Branches 4405 4405
=============================================
- Hits 30355 30351 -4
- Misses 9512 9516 +4
Partials 2124 2124
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
i will check the open source agreement and get back to you soon |
The Pr can't be merged because cla can't pass. The commit is from CharlesChangOkx, but PR is from SoilChang |
sorry ya i use company laptop to commit it, which give rise to a lot of issue. im still asking my company if i can sign those contribution agreements. i don't think it will get resolved soon. i think i will just my own laptop and do this contribution on my own time so speed up the progress. |
|
f09980f
to
90a118a
Compare
90a118a
to
acfec86
Compare
i have updated the MR from my own laptop. |
i see that it says the open-source contribution agreements have been signed. I think this is ready for merge. Please let me know if there are any other blockers. thank you. |
Please do not create a Pull Request without creating an issue first.
What is the purpose of the change
This change improves the clarity and professionalism of logging messages across various components. Specifically, it updates log messages related to resource destruction processes to ensure consistent grammar, clarity, and message intent.
Brief changelog
Updated log messages in ConfigHttpClientManager to clarify resource destruction stages.
Updated log messages in NamingHttpClientManager for better grammar and meaning.
Refined log messages in ThreadPoolManager to ensure clarity about the shutdown process.
Improved log messages in HttpClientBeanHolder to clearly describe the start and completion of HTTP client destruction.
Enhanced logging in NotifyCenter to make resource cleanup messages more professional and meaningful.
Updated HttpClientManager in the config and naming modules to use consistent and clear log messages during the destruction of HTTP clients.
Verifying this change
visual verifying
Follow this checklist to help us incorporate your contribution quickly and easily:
[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true
to make sure basic checks pass. Runmvn clean install -DskipITs
to make sure unit-test pass. Runmvn clean test-compile failsafe:integration-test
to make sure integration-test pass.