fix: ispaused invalid iterator #205
Open
+12
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kenzzer
requested changes
Feb 14, 2025
Comment on lines
+259
to
+267
| bool isValidIterator(List<CHook>::iterator &myIter, List<CHook> &myList) { | ||
| for (auto iter = myList.begin(); iter != myList.end(); ++iter) { | ||
| if (iter == myIter) { | ||
| return true; | ||
| } | ||
| } | ||
| return false; | ||
| } | ||
|
|
There was a problem hiding this comment.
This is inefficient, there are better ways to go about this.
There was a problem hiding this comment.
what are the better ways? using this?
return myIter != myList.end() && std::distance(myList.begin(), myIter) >= 0;
| void SkipPaused(List<CHook>::iterator &iter, List<CHook> &list) | ||
| { | ||
| while (iter != list.end() && iter->IsPaused()) | ||
| if (!iter || !isValidIterator(iter, list)) |
There was a problem hiding this comment.
What's your basis for believing iter can be null ? And if it is null, does checking only for that fixes your crash ? (I'm mainly hoping we can avoid having to iterate the entire the list)
There was a problem hiding this comment.
i have edited my PR description to answer what you asked for
done! thanks for the info |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes that sort of crash:
Which happens on this function call:
metamod-source/core/sourcehook/sourcehook_impl_chook.h
Line 95 in 2009298
Coming from here:
metamod-source/core/sourcehook/sourcehook_impl.h
Line 259 in 4bc5a3a
So from my understanding, this->m_Paused crashes because
thisis nullThat's why i am trying to avoid any call with iter being an invalid iterator
i added this on our prod servers since 04/02/2025 and we have not encountered this crash again: