Fix hanging middleman #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is currently an issue with middleman-autoprefixer which causes middleman to hang: middleman/middleman-autoprefixer#33 When this happens, middleman no longer responds to requests and does not refresh on source changes. Moving the `activate :autoprefixer` command into the `context.configure :build` block seems to fix this and middleman behaves normally.
jonathanglassman
approved these changes
Oct 24, 2018
|
Is it possible to get a new incremental release out with this fix? I know a lot of people struggle with this and it's great to finally have a fix. |
Merged
|
This has now been released! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is currently an issue with middleman-autoprefixer which causes
middleman to hang: middleman/middleman-autoprefixer#33
When this happens, middleman no longer responds to requests and does not
refresh on source changes.
Moving the
activate :autoprefixercommand into thecontext.configure :buildblock seems to fix this and middleman behaves normally.