-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow multiple workspaces per buffer #53
base: master
Are you sure you want to change the base?
Conversation
37b4a04
to
fad3c20
Compare
FYI, I probably won't have time to look at this soon. Thanks for your patience. |
FYI, due to some IRL issues and computer problems, I haven't had time to work on Emacs stuff. It will probably be a while longer before I can look at this carefully. |
71a32f5
to
fdb8193
Compare
Don't worry, living comes first. Actually I think I'll move the PR back to draft as I'm only starting using the features I'd like to add and I'm seeing a few bugs/usability issues that I'm fixing |
c8bb2a8
to
5fda7f5
Compare
Ok, thanks. Let me know when you're ready for it to be looked at again. |
For reference, this PR's ideas were previously discussed at #49. Thinking about this a bit more, I think what's needed is:
|
We should probably discuss these ideas in an issue rather than a PR, so: #69 |
5fda7f5
to
d5346b6
Compare
- Rename `bufler-workspace-name` to `bufler-workspace-names` to show it can hold multiple values - Add prefix to workspace names in the groups (as a defcustom) - Make `bufler-workspace-buffer-name-workspace` add to list of buffer-local workspace value instead of replacing it - Use another version of `seq-group-by` in `bufler-group-tree` that adds an element in multiple groups if the grouping function returns a list. - Add utility functions to access/manage named workspaces + Add function to list all buffers in a named workspace + Add function to clean up a single named workspace Co-authored-by: Adam Porter <[email protected]>
d5346b6
to
3d3bb8c
Compare
9333643
to
84e837f
Compare
Hello again,
I hope this time I'll be clear enough, I tend to over-complicate things and I try to work on that :(
Rescoping the previous messy PR I made. The point is that here, we do not need non-consuming groups in order to allow multiple workspaces for a single buffer.
Feature summary
The workflow I want to cover is :
bufler-workspace-frame-set
(bufler-workspace-buffer-name-workspace "Bufler")
bufler-workspace-frame-set
(bufler-workspace-buffer-name-workspace "Emacs Config")
Then, if I list buffers with
M-x bufler
, I want to see thebufler.el
buffer under 2 different named workspaces.Change summary
bufler-workspace-name
tobufler-workspace-names
to show itcan hold multiple values
bufler-workspace-buffer-name-workspace
add to list ofbuffer-local workspace value instead of replacing it
seq-group-by
inbufler-group-tree
that addsan element in multiple groups if the grouping function returns a list.
For the last point, it would be better to use
cl-defmethod
to overridethe
seq-group-by
function only when grouping workspaces but currentlyno version tried work. Last try :