change quality checks to run on PRs along with pushes (#48)

alteryx · Jul 31, 2024 · 01a3c16 · 01a3c16
1 parent c9d846e
commit 01a3c16
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 4 deletions.
diff --git a/.github/workflows/quality-checks.yml b/.github/workflows/quality-checks.yml
@@ -1,6 +1,8 @@
 name: quality checks
 
-on: push
+on: 
+  push:
+  pull_request:
 
 jobs:
   ruff-lint:

diff --git a/src/grasshopper/lib/configuration/gh_configuration.py b/src/grasshopper/lib/configuration/gh_configuration.py
@@ -104,7 +104,6 @@ class ConfigurationConstants:
             "typecast": typecast_bool,
             "default": False,
         },
-
         "influx_verify_ssl": {
             "opts": ["--influx_verify_ssl"],
             "attrs": {

diff --git a/src/grasshopper/lib/grasshopper.py b/src/grasshopper/lib/grasshopper.py
@@ -41,7 +41,6 @@ def log(self) -> None:
 
     @property
     def influx_configuration(self) -> dict[str, Optional[Union[bool, str]]]:
-
         """Extract the influx related configuration items.
 
         The InfluxDbSettings object should only get keys if there is a
@@ -70,7 +69,9 @@ def influx_configuration(self) -> dict[str, Optional[Union[bool, str]]]:
 
         configuration["ssl"] = self.global_configuration.get("influx_ssl", False)
 
-        configuration["verify_ssl"] = self.global_configuration.get("influx_verify_ssl", False)
+        configuration["verify_ssl"] = self.global_configuration.get(
+            "influx_verify_ssl", False
+        )
 
         return configuration
 

diff --git a/tests/unit/conftest.py b/tests/unit/conftest.py
@@ -51,6 +51,8 @@ def current_global_defaults():
         "cleanup_s3": True,
         "slack": False,
         "influx": False,
+        "influx_ssl": False,
+        "influx_verify_ssl": False,
         "report_portal": False,
         "rp_launch_name": "Grasshopper Performance Test Run | Launch name unknown",
         "rp_launch": "Grasshopper Performance Test Run | Launch name unknown",

diff --git a/tests/unit/test_grasshopper_configuration_fixtures.py b/tests/unit/test_grasshopper_configuration_fixtures.py
@@ -25,6 +25,8 @@ def expected_global_defaults():
         "cleanup_s3": True,
         "slack": False,
         "influx": False,
+        "influx_ssl": False,
+        "influx_verify_ssl": False,
         "report_portal": False,
         "rp_launch_name": "Grasshopper Performance Test Run | Launch name unknown",
         "rp_launch": "Grasshopper Performance Test Run | Launch name unknown",