Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue fix: Set ulimit in Grasshopper launch function #29

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

jmfiola
Copy link
Collaborator

@jmfiola jmfiola commented Dec 9, 2023

Since Grasshopper is not calling the main method of locust in locust.main, we were not making use of it's code where it automatically sets the ulimit. So, I've grabbed that code from locust's main function, adapted it a bit, and made it into it's own static function as a part of the Grasshopper class, which then gets called in the launch function.

@jmfiola jmfiola linked an issue Dec 9, 2023 that may be closed by this pull request
Copy link
Contributor

@alteryx-sezell alteryx-sezell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just left one suggestion.

src/grasshopper/lib/grasshopper.py Show resolved Hide resolved
@jmfiola jmfiola merged commit ac3f4c6 into main Dec 13, 2023
4 checks passed
@jmfiola jmfiola deleted the 28-set-ulimit-before-test-run branch September 23, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSONDecodeError while running tests
2 participants