Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change quality checks to run on PRs along with pushes #48

Merged
merged 2 commits into from
Jul 31, 2024
Merged

change quality checks to run on PRs along with pushes #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1962bb5
change quality checks to run on PRs along with pushes
jmfiola Jul 31, 2024
187cf8c
fix a few tests
jmfiola Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/quality-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
name: quality checks

on: push
on:
push:
pull_request:

jobs:
ruff-lint:
Expand Down
1 change: 0 additions & 1 deletion src/grasshopper/lib/configuration/gh_configuration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,6 @@ class ConfigurationConstants:
"typecast": typecast_bool,
"default": False,
},

"influx_verify_ssl": {
"opts": ["--influx_verify_ssl"],
"attrs": {
Expand Down
5 changes: 3 additions & 2 deletions src/grasshopper/lib/grasshopper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ def log(self) -> None:

@property
def influx_configuration(self) -> dict[str, Optional[Union[bool, str]]]:

"""Extract the influx related configuration items.
The InfluxDbSettings object should only get keys if there is a
Expand Down Expand Up @@ -70,7 +69,9 @@ def influx_configuration(self) -> dict[str, Optional[Union[bool, str]]]:

configuration["ssl"] = self.global_configuration.get("influx_ssl", False)

configuration["verify_ssl"] = self.global_configuration.get("influx_verify_ssl", False)
configuration["verify_ssl"] = self.global_configuration.get(
"influx_verify_ssl", False
)

return configuration

Expand Down
2 changes: 2 additions & 0 deletions tests/unit/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,8 @@ def current_global_defaults():
"cleanup_s3": True,
"slack": False,
"influx": False,
"influx_ssl": False,
"influx_verify_ssl": False,
"report_portal": False,
"rp_launch_name": "Grasshopper Performance Test Run | Launch name unknown",
"rp_launch": "Grasshopper Performance Test Run | Launch name unknown",
Expand Down
2 changes: 2 additions & 0 deletions tests/unit/test_grasshopper_configuration_fixtures.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ def expected_global_defaults():
"cleanup_s3": True,
"slack": False,
"influx": False,
"influx_ssl": False,
"influx_verify_ssl": False,
"report_portal": False,
"rp_launch_name": "Grasshopper Performance Test Run | Launch name unknown",
"rp_launch": "Grasshopper Performance Test Run | Launch name unknown",
Expand Down
Loading