-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #155 earnings calendar #242
base: master
Are you sure you want to change the base?
Conversation
…ows the same logic as investing.com: https://www.investing.com/earnings-calendar/ This allows to fetch company earnings updates: EPS, forecast EPS, revenue, forecast revenue etc. + open todo tasks
Codecov Report
@@ Coverage Diff @@
## master #242 +/- ##
==========================================
- Coverage 90.96% 90.93% -0.04%
==========================================
Files 26 26
Lines 4902 5007 +105
==========================================
+ Hits 4459 4553 +94
- Misses 443 454 +11 |
Cool @Amiram1! Thanks for the great work here 💪🏻 Should I wait until you complete the TODOs you have on your initial comment or do you want me to merge this now and iterate over a new PR to solve those? Thanks a lot! 🤗 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, you did a great work here, taking care of the docstrings and the tests too! 💪🏻 Keep it up!
Thanks @alvarobartt happy to help, up to you if you want to merge it as is :-) I'm not sure when I'll have time to continue the open tasks |
Ok @Amiram1 then before merging this PR, could you please explain this 2 points you previously mentioned in just a few lines so that I can report those in order to tackle them later?
Thanks a lot! 👍🏻 |
Of course - 2 - earnings_time appear in https://www.investing.com/earnings-calendar/ as moon (After Markets Close) or sun icons (Before Markets Open). We need to parse correctly each row and add to earnings_time |
great function. this is already available in the master or not yet? |
Enhancement following #155
New earnings_calendar api based on the economic calendar api and follows the same logic as investing.com:
https://www.investing.com/earnings-calendar/
This allows to fetch company earnings updates: EPS, forecast EPS, revenue, forecast revenue, market cap etc.
basic usage:
3 open tasks to resolve:
would it be better to extract the shared logic with economic_calendar instead of the duplicated code?
sectors don't work yet, need to check investing.com API for the exact sectors definitions
missing the earnings_time parser (BMO, AMC), seems to be inconsistent in investing.com