-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added handling child lists #51
base: master
Are you sure you want to change the base?
Conversation
a26fd54
to
4f010d2
Compare
4f010d2
to
adadda2
Compare
Thank you for your contribution. Could you share an example in YAML format for the result that you shared in this PR? I would like to include the example in this repository: https://github.com/amenezes/spring_config |
Hello
Also, I would like to ask you to re-run the tests for my commit. They were not completed due to |
Really sorry for delay. But I have some doubts. I'm include the configuration that you shared with me and I tried reproduce the behavior related in the first comment, but using the command line option and the output, initially, make sense. For example: $ python -m config client simpleweb000 -f environments
╭────────────────────────────────────────────────── report for filter: 'environments' ───────────────────────────────────────────────────╮
│ [ │
│ { │
│ "properties": [ │
│ { │
│ "name": "property1", │
│ "schema": { │
│ "minLength": 1, │
│ "type": "string" │
│ } │
│ }, │
│ { │
│ "name": "property2", │
│ "schema": { │
│ "type": "string" │
│ } │
│ } │
│ ], │
│ "type": "dev" │
│ }, │
│ { │
│ "properties": [ │
│ { │
│ "name": "property1", │
│ "schema": { │
│ "type": "string" │
│ } │
│ } │
│ ], │
│ "type": "stage" │
│ } │
│ ] │
╰────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯ $ python -m config client simpleweb000 -f environments.0.properties
╭──────────────────────────────────────────── report for filter: 'environments.0.properties' ────────────────────────────────────────────╮
│ [ │
│ { │
│ "name": "property1", │
│ "schema": { │
│ "minLength": 1, │
│ "type": "string" │
│ } │
│ }, │
│ { │
│ "name": "property2", │
│ "schema": { │
│ "type": "string" │
│ } │
│ } │
│ ] │
╰────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯ Could you share some more examples with me using the config-server running as the example below: docker run -it --rm -p 8888:8888 \
hyness/spring-cloud-config-server:3.1.0-jre17 \
--spring.cloud.config.server.git.uri=https://github.com/amenezes/spring_config |
Hi guys ! Any idea if this issue could be handled soon ? It would be great for us to have this feature working asap |
Hello, @amenezes I'm so sorry for delay. I have another output.
Conf directory:
Result:
|
For now, the library does not parse child lists and leave them in this format:
This PR will change the result dictionary to the next format: