Update logger to use filename instead of package and add more logging

amosyuen · Feb 3, 2023 · fc025e4 · fc025e4
1 parent 2f46d86
commit fc025e4
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 5 deletions.
diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -1,4 +1,5 @@
 {
+  "python.linting.pylintArgs": ["--rcfile=setup.cfg"],
   "python.linting.pylintEnabled": true,
   "python.linting.enabled": true,
   "python.pythonPath": "venv/bin/python",

diff --git a/custom_components/tplink_deco/__init__.py b/custom_components/tplink_deco/__init__.py
@@ -47,7 +47,7 @@
 from .coordinator import TpLinkDecoData
 from .coordinator import TplinkDecoUpdateCoordinator
 
-_LOGGER: logging.Logger = logging.getLogger(__package__)
+_LOGGER: logging.Logger = logging.getLogger(__name__)
 
 
 async def async_create_and_refresh_coordinators(

diff --git a/custom_components/tplink_deco/api.py b/custom_components/tplink_deco/api.py
@@ -30,7 +30,7 @@
 
 PKCS1_v1_5_HEADER_BYTES = 11
 
-_LOGGER: logging.Logger = logging.getLogger(__package__)
+_LOGGER: logging.Logger = logging.getLogger(__name__)
 
 
 def byte_len(n: int) -> int:

diff --git a/custom_components/tplink_deco/config_flow.py b/custom_components/tplink_deco/config_flow.py
@@ -21,7 +21,7 @@
 from .const import DEFAULT_SCAN_INTERVAL
 from .const import DOMAIN
 
-_LOGGER: logging.Logger = logging.getLogger(__package__)
+_LOGGER: logging.Logger = logging.getLogger(__name__)
 
 
 def _get_auth_schema(data: dict[str:Any]):

diff --git a/custom_components/tplink_deco/coordinator.py b/custom_components/tplink_deco/coordinator.py
@@ -20,7 +20,7 @@
 from .const import SIGNAL_CLIENT_ADDED
 from .const import SIGNAL_DECO_ADDED
 
-_LOGGER: logging.Logger = logging.getLogger(__package__)
+_LOGGER: logging.Logger = logging.getLogger(__name__)
 
 
 def bytes_to_bits(bytes_count):
@@ -178,6 +178,7 @@ async def _async_update_data(self):
                 deco_added = True
                 deco = TpLinkDeco(mac)
                 deco.update(new_deco)
+                _LOGGER.debug("_async_update_data: Found new deco mac=%s", deco.mac)
             else:
                 deco.update(new_deco)
             decos[mac] = deco
@@ -257,6 +258,9 @@ async def _async_update_data(self):
                 if client is None:
                     client_added = True
                     client = TpLinkDecoClient(client_mac)
+                    _LOGGER.debug(
+                        "_async_update_data: Found new client mac=%s", client.mac
+                    )
                 client.update(deco_client, deco_mac, utc_point_in_time)
                 clients[client_mac] = client
 

diff --git a/custom_components/tplink_deco/device_tracker.py b/custom_components/tplink_deco/device_tracker.py
@@ -42,7 +42,7 @@
 from .coordinator import TplinkDecoClientUpdateCoordinator
 from .coordinator import TplinkDecoUpdateCoordinator
 
-_LOGGER: logging.Logger = logging.getLogger(__package__)
+_LOGGER: logging.Logger = logging.getLogger(__name__)
 
 
 async def async_setup_entry(
@@ -69,6 +69,7 @@ def add_untracked_decos():
             if mac in tracked_decos:
                 continue
 
+            _LOGGER.debug("add_untracked_decos: Adding deco mac=%s", deco.mac)
             new_entities.append(TplinkDecoDeviceTracker(coordinator, deco))
             tracked_decos.add(mac)
 
@@ -95,6 +96,7 @@ def add_untracked_clients():
             if mac in tracked_clients:
                 continue
 
+            _LOGGER.debug("add_untracked_clients: Adding client mac=%s", client.mac)
             new_entities.append(
                 TplinkDecoClientDeviceTracker(
                     coordinator_decos, coordinator_clients, client