Currentmedia #6
Merged
Currentmedia #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 17, 2010 01:39
…Add a note smiley and then the formatted media
…theme manager to get the smiley
|
New commit added with the requested changes :) |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit message for more information.
The current_media part was just not working for me at all and throwing an error. This is just an idea on how to fix it. Still learning my way around so I think there might be a better way to get the smiley path. Also I think directly putting the media formatting right here might be wrong.
Let me know what you guys think and how I can improve this part :)
papyon_contact.current_media in this code is a tuple in case you're wondering (title, artist)