Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ambient-light-sensor=() Fix browser warning: Error with Permissions-Policy header: Unrecognized feature: 'ambient-light-sensor'. #203

Merged

Conversation

damienbod
Copy link
Contributor

Fix browser warning for default PermissionPolicy

Error with Permissions-Policy header: Unrecognized feature: 'ambient-light-sensor'.

@andrewlock
Copy link
Owner

Hmmm 🤔 So, this directive is marked as experimental, but then so are 90% of the permission policy directives and it's a suggested directive by OWASP.

The main difference is that it's the only of those directives which are experimental in Chrome - most of them are missing from Firefox, and a couple of others are missing from Edge..

I feel like the browsers shouldn't be making this an error, it should just be informational - I should be able to over-specify permissions so that they apply once they are supported 😅

But fundamentally, this gives a bit of an issue 🤔 Should the default be only those that are supported everywhere? Because that's very few... Tying everything to Chrome's support feels... wrong 🤔

@damienbod
Copy link
Contributor Author

This fixes the warning in Chrome, Edge and Brave, Firefox doesn't display the warnings, so I think it would be better.

Safari, I don't know, but this works with 3 of the main browsers.

@andrewlock
Copy link
Owner

meh, sold, thanks 😂

@andrewlock andrewlock merged commit 8ecda56 into andrewlock:main Oct 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants