Support for 5 card and 6 card Omaha. #86
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Andrew et al.
I was trying to add support for 6 card Omaha, but I found out that there was already support for it. However it seemed to be incomplete.
The pseudo-switch statements first bundle o5 and o6, and then they set the amount of pocket cards to 4, effectively making it 4card omaha.
I believe this fixes it and implements the capacity to evaluate 6 and 5 card omaha, hi and lo.
Additionally, I removred some unused lines, presumably during an attempt to migrate from a hard coded omaha evaluator to a universal evaluator. Altough the jump was never made.
I chose not to use the Universal version in Omaha 4, so as to avoid breaking changes, but this Universal version is used for 5 and 6 card of course, which naturally provides a testing phase before it would get implemented for Omaha 4.
No tests are added, but there's definitely room. It's worth noting that there were tests for O5 and O6, but this issue was not caught because the tests use the evaluation functions directly instead of the command line. And the bug is present in the Alloc.cpp file which presumably allocates evaluation functions to command line options.