Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for 5 card and 6 card Omaha. #86

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

TZubiri
Copy link

@TZubiri TZubiri commented Jan 1, 2025

Hello Andrew et al.

I was trying to add support for 6 card Omaha, but I found out that there was already support for it. However it seemed to be incomplete.

The pseudo-switch statements first bundle o5 and o6, and then they set the amount of pocket cards to 4, effectively making it 4card omaha.

I believe this fixes it and implements the capacity to evaluate 6 and 5 card omaha, hi and lo.

Additionally, I removred some unused lines, presumably during an attempt to migrate from a hard coded omaha evaluator to a universal evaluator. Altough the jump was never made.

I chose not to use the Universal version in Omaha 4, so as to avoid breaking changes, but this Universal version is used for 5 and 6 card of course, which naturally provides a testing phase before it would get implemented for Omaha 4.

No tests are added, but there's definitely room. It's worth noting that there were tests for O5 and O6, but this issue was not caught because the tests use the evaluation functions directly instead of the command line. And the bug is present in the Alloc.cpp file which presumably allocates evaluation functions to command line options.

@TZubiri
Copy link
Author

TZubiri commented Jan 1, 2025

Manual test case to confirm 5th and 6th card are in use:

Omaha 4
2s2d2h2c 0% equity
3s3d3h3c 100% equity

Omaha 6
2s2d2h2cAsAd 82% equity
3s3d3h3c8s8d 18% equity

It checks out that the odds of each player in the second scenario work out to almost exactly the same as Aces vs other pocket pairs in Hold Em, with some difference due to the 8 other pocket burnt cards, which should increase odds for the underpair.

@TZubiri TZubiri mentioned this pull request Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant