Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular/ssr): disable component boostrapping when running route extraction #29183

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Dec 19, 2024

This commit fixes an issue where the components where still being bootstrapping when using provideAppInitializer

Closes #29131

@alan-agius4 alan-agius4 requested a review from dgp1130 December 19, 2024 06:56
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: minor This PR is targeted for the next minor release labels Dec 19, 2024
@alan-agius4 alan-agius4 force-pushed the comp-boostratp-ng-routes branch from 28c5d2b to f11f65a Compare December 19, 2024 07:15
…extraction

This commit fixes an issue where the components where still being
boostrapped when using `provideAppInitializer`

Closes angular#29131
@alan-agius4 alan-agius4 force-pushed the comp-boostratp-ng-routes branch from f11f65a to 7c462af Compare December 19, 2024 09:21
@alan-agius4 alan-agius4 requested review from AndrewKushnir and removed request for dgp1130 December 19, 2024 16:35
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 19, 2024
@alan-agius4 alan-agius4 merged commit 3feecdd into angular:main Dec 19, 2024
30 of 31 checks passed
@alan-agius4 alan-agius4 deleted the comp-boostratp-ng-routes branch December 19, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: @angular/ssr target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Component bootstrapping during route extraction is not disabled when using provideAppInitializer()
2 participants