Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: migrate @schematics/angular to ts_project #29217

Merged
merged 1 commit into from
Dec 23, 2024
Merged

build: migrate @schematics/angular to ts_project #29217

merged 1 commit into from
Dec 23, 2024

Conversation

clydin
Copy link
Member

@clydin clydin commented Dec 23, 2024

The @schematics/angular package has been migrated to the rules_js ts_project rule.

@clydin
build: migrate @schematics/angular to ts_project
16c1f0d 
The `@schematics/angular` package has been migrated to the `rules_js` ts_project rule.
@clydin clydin added the target: patch This PR is targeted for the next patch release label Dec 23, 2024
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Dec 23, 2024
@clydin clydin requested a review from josephperrott December 23, 2024 16:08
@clydin clydin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Dec 23, 2024
@clydin clydin requested a review from devversion December 23, 2024 16:18
josephperrott
josephperrott approved these changes Dec 23, 2024
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clydin clydin removed the request for review from devversion December 23, 2024 17:04
@clydin clydin added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 23, 2024
@clydin clydin merged commit d4a4bc8 into angular:main Dec 23, 2024
34 checks passed
@clydin
Copy link
Member Author

clydin commented Dec 23, 2024

The changes were merged into the following branches: main, 19.0.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephperrott josephperrott josephperrott approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clydin @josephperrott