Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Update Length.SolarRadius definition per IAU Res. B3 #1426

Merged
merged 2 commits into from
Sep 29, 2024
Merged

✨Update Length.SolarRadius definition per IAU Res. B3 #1426

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d657c0d
Use the Nominal Solar Radius as defined in IAU Res. B3
saadsidqui Sep 22, 2024
0395d14
Fix tests
saadsidqui Sep 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Common/UnitDefinitions/Length.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,8 +381,8 @@
{
"SingularName": "SolarRadius",
"PluralName": "SolarRadiuses",
"FromUnitToBaseFunc": "{x} * 6.95510000E+08",
"FromBaseToUnitFunc": "{x} / 6.95510000E+08",
"FromUnitToBaseFunc": "{x} * 6.95700e8",
"FromBaseToUnitFunc": "{x} / 6.95700e8",
"XmlDocSummary": "Solar radius is a ratio unit to the radius of the solar system star, the sun.",
"XmlDocRemarks": "https://en.wikipedia.org/wiki/Stellar_classification",
"Localization": [
Expand Down
2 changes: 1 addition & 1 deletion UnitsNet.Tests/CustomCode/LengthTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ public class LengthTests : LengthTestsBase

protected override double ParsecsInOneMeter => 3.2407790389471100000000000E-17;

protected override double SolarRadiusesInOneMeter => 1.43779384911791000E-09;
protected override double SolarRadiusesInOneMeter => 1.4374011786689664E-09;

protected override double ChainsInOneMeter => 0.0497096953789867;

Expand Down