Update the Samples (v6) #1479
Update the Samples (v6) #1479
Conversation
lipchev
commented
Dec 28, 2024
lipchev
commented
- projects converted to Sdk style
- added a new Directory.Packages for the Samples folder and updated the references to the latest (working) versions
- minor fixes to the UnitConverter.Wpf
- projects converted to Sdk style - added a new Directory.Packages for the Samples folder and updated the references to the latest (working) versions - minor fixes to the UnitConverter.Wpf
|
I've been experimenting (locally) with the following trick:
I'm not sure if this is going to work on the build server, so after this is merged- I thought I'd give it a try and see what happens.. Ideally, along with the godzilla PR I was hoping to introduce a new project in the samples called |
- Remove `CommonServiceLocator` nuget, use `Prism.Ioc.ContainerLocator.Container` instead - Remove implicit `Unity.Container` nuget, bundled by `Prism.Unity` - Upgrade nugets, remove version overrides
| <PackageVersion Include="Prism.Wpf" Version="7.1.0.431" /> | ||
| <PackageVersion Include="Unity.Abstractions" Version="5.11.7" /> | ||
| <PackageVersion Include="Unity.Container" Version="5.8.11" /> | ||
| </ItemGroup> |
There was a problem hiding this comment.
I was a little bit on the fence on this one, since sample apps are so varied and use so little common code, but then again they are rarely touched and this may just help manage upgrades a little bit. We can keep it.
| <HintPath>..\..\packages\Prism.Wpf.7.1.0.431\lib\net45\Prism.Wpf.dll</HintPath> | ||
| </Reference> | ||
| <Reference Include="System" /> | ||
| <!-- managing these dependencies is a nightmare --> |
There was a problem hiding this comment.
I have no experience with these nugets, seems weird we need to override to specific versions and not just use latest defined in Directory.Packages.props?
Or is Directory.Packages.props not supported in this project?
There was a problem hiding this comment.
Okay I think I figured out a solution where we can upgrade all nugets and fix the dependency issue, see 0f552b9.
Also added solution files for scripts and .props file.
On a related note, fuck WPF and particularly fuck XAML. What a trainwreck to work with.
There was a problem hiding this comment.
Oh, come on.. I love WPF. They just need to update the XAML to the latest specs, and fix those 20 year old issues with CollectionChanged and what not.. 😄
There was a problem hiding this comment.
..and we'll be good for another 20 years..
