Skip to content
This repository has been archived by the owner on Jan 26, 2021. It is now read-only.

Migrated to Bootstrap 4 #517

Closed
wants to merge 2 commits into from
Closed

Conversation

ritwickraj78
Copy link
Contributor

Description

Updated the bootstrap version from 3 to 4 so that developers can now work on the latest vesion.

Fixes #449

Type of Change:

Delete irrelevant options.

  • Quality Assurance

Code/Quality Assurance Only

  • New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

Tested locally on my system. Updating to version 4 breaks nothing.

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • Any dependent changes have been merged

Code/Quality Assurance Only

  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@ritwickraj78
Copy link
Contributor Author

@abhi20161997 I have made the necessary changes. Could you please review the changes?

@abhi20161997
Copy link
Contributor

abhi20161997 commented Apr 3, 2020

@ritwickraj78 LGTM @sammy1997 Please can you have a look too ?

@sammy1997
Copy link
Contributor

Still, 2 commits on this. :( Please check it

@sakshi1499
Copy link

@ritwickraj78 Can you squash and make it to one commit? We can merge then.

@ritwickraj78
Copy link
Contributor Author

ritwickraj78 commented Apr 9, 2020

@sakshi1499 Sure I'll do the needful. And also sorry for the delay

@ritwickraj78
Copy link
Contributor Author

@sakshi1499 @sammy1997 Seems I have pulled from the wrong branch before making the PR. So I am closing this PR and will be opening a new one. Sorry for the inconvenience.

@sammy1997
Copy link
Contributor

sammy1997 commented Apr 10, 2020

@ritwickraj78 Yeah go ahead make a new PR. I am closing this

@sammy1997 sammy1997 closed this Apr 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrating from Bootstrap3 to Bootstrap4
4 participants