Skip to content
This repository has been archived by the owner on Jan 26, 2021. It is now read-only.

Migrating to Bootstrap4 #524

Closed
wants to merge 1 commit into from

Conversation

ritwickraj78
Copy link
Contributor

Description

Migrated to Bootstrap 4 from Bootstrap 3.

Fixes #449

Type of Change:

Delete irrelevant options.

  • Quality Assurance

Code/Quality Assurance Only

  • New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

All local as well as CI tests pass. It has been made sure that nothing is broken while migrating.

Checklist:

Delete irrelevant options.

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials

Code/Quality Assurance Only

  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@sakshi1499
Copy link

@ritwickraj78 Have you tested it in your local system?
image
The above image is from the documentation.
image
Can we implement this in styles.css as well?

@ritwickraj78
Copy link
Contributor Author

ritwickraj78 commented Apr 27, 2020

@sakshi1499 Even I went through the documentation and it seems changing to bootstrap 4 would be quite a Herculean task. There have to be more changes than I expected. So shall I continue or leave it for now? Because bootstrap 3 is not something which would deprecate.

@sakshi1499
Copy link

@ritwickraj78 Yes I agree there will be many changes. @sammy1997 What do you suggest?

@chahat99 chahat99 requested a review from mayburgos April 28, 2020 18:00
@sakshi1499
Copy link

@ritwickraj78 I would suggest you to go ahead and properly migrate to Bootstrap4. Take time, I understand that it will be a huge task.

@rpattath rpattath added the Status: Changes Requested Changes are required to be done by the PR author. label Jun 1, 2020
@sammy1997
Copy link
Contributor

@sakshi1499 @ritwickraj78 I think we should close this and make the issue available for the community

@sakshi1499
Copy link

@sammy1997 Yes. I second you on this. Closing this and making it available to the community. :)

@sakshi1499 sakshi1499 closed this Jun 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Status: Changes Requested Changes are required to be done by the PR author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrating from Bootstrap3 to Bootstrap4
4 participants