Skip to content
This repository has been archived by the owner on Jan 26, 2021. It is now read-only.

docs : improved the docker image , docker-compose and Dockerfile. #998

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

husainattar
Copy link

Description

Updated the docker-compose.yml,settings.py, Dockerfile and Readme.md
for easy project installation process through docker.

Fixes # 915

Type of Change:

Delete irrelevant options.

  • Code
  • Documentation

Code/Quality Assurance Only

  • Bugfix (non-breaking change which fixes an issue)

How Has This Been Tested?

docker

Checklist:

Delete irrelevant options.

  • I have performed a self-review of my own code or materials
  • I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Code/Quality Assurance Only

  • My changes generate no new warnings

@theyashshahs
Copy link
Contributor

@husainattar please change the PR title according to the commit styles

@husainattar husainattar changed the title Updated the docker image , docker-compose and Dockerfile docs : improved the docker image , docker-compose and Dockerfile. Jul 22, 2020
@husainattar
Copy link
Author

Yes sure @yashshah2820. One more thing that this issue wasn't labelled so I have just labelled the PR under docs same as the portal docker issue #581.

@husainattar husainattar requested a review from theyashshahs July 22, 2020 19:56
theyashshahs
theyashshahs previously approved these changes Jul 24, 2020
Copy link
Contributor

@theyashshahs theyashshahs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@husainattar squash the commits into one as you have 13 commits in the PR

@theyashshahs theyashshahs added Status: Needs Review PR needs an additional review or a maintainer's review. Status: Changes Requested Changes are required to be done by the PR author. labels Jul 24, 2020
@husainattar
Copy link
Author

husainattar commented Jul 26, 2020

Hi @yashshah2820 I have squashed the commits and resolve the error due to which PR's build failed and Before squashing comments all test passed but now travisCI failed.

@theyashshahs
Copy link
Contributor

@husainattar coverage tests are failing

@husainattar
Copy link
Author

I am sorry @yashshah2820 actually I am not familiar with testing I will be grateful if anyone can help me to resolve this because pull request build was successful before squashing comments.

@mayburgos mayburgos requested a review from satya7289 July 30, 2020 18:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Status: Changes Requested Changes are required to be done by the PR author. Status: Needs Review PR needs an additional review or a maintainer's review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants