icx_vlan - add stack and modules - fix purge with aggregate #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll check what's wrong with test_icx_vlan_interfaces_cndt and test_icx_vlan_tagged_cndt |
|
CI tests failled with :00:30 ERROR! Error when getting collection version metadata for ansible.utils:2.6.0 from default (https://galaxy.ansible.com/api/) (HTTP Code: 429, Message: Too Many Requests Code: Unknown) I think it just need to be run again to be cleared. |
ansibullbot
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Remove the hardcoded "ethernet 1/1/" to allow stack and modules to work.
Fix module not adding interfaces when purge = true with aggregate
"Fixes #268"
ISSUE TYPE
COMPONENT NAME
icx_vlan
ADDITIONAL INFORMATION
Picked up on PR#279 which seems to be abandoned.
I use ratneshnagori work and made a few tweaks to make it works.
I'll add the changelog fragment when the PR number will be generated.
I can't see the CI failures on the other PR because it's too old. Maybe it need some more adjustments.
Be kind, it's my first PR.. ever.