Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EC2: Change logic of deleting resources #279

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

klaphi
Copy link

@klaphi klaphi commented Oct 8, 2024

This PR changes the logic of deleting resources of the EC2 driver. Without that change security groups and keypairs will stay because the tasks will be skipped.

The tasks Write Molecule instance configs changes the when condition of the block immediately. This will skip the following tasks regardless of their when conditions. Moving the tasks Write Molecule instance configs to the end of the block will execute the cleanup of Security groups and keypairs according to their own when condition.

…, because this task changes the when condition of the block immediately and following tasks will be skipped regardless ot their when condition.
@klaphi
Copy link
Author

klaphi commented Oct 8, 2024

This will fix: #280

@apatard
Copy link
Member

apatard commented Dec 20, 2024

While the change looks fine (the cleanup should always be done in the end imho), some questions for you:

  • I've given a brief look and I'm having hard time to understand how it's solving your issue. Can you please give more details ?
  • Which version of molecule are you using ? iirc, the cookiecutter stuff is not used anymore theses days.

@apatard apatard added bug Something isn't working ec2 Amazon EC2 labels Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ec2 Amazon EC2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants