forked from parnurzeal/gorequest
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add check timeout on retry #1
Open
anthonyhartanto
wants to merge
25
commits into
master
Choose a base branch
from
develop
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add a logger interface, and make the "logging" more flexible
- Don't allow buffers with nil contents to be passed to `http.NewRequest' constructor. Fixes errors like: Get https://[SOME-WEBSITE]: stream error: stream ID 1; REFUSED_STREAM See parnurzeal#136 for further information.
nil buffer fix
correcting example's use of time.Second
Update README.md
…ues. Also add a function `AppendHeader()` to support mutiple values of Header.
Parenthesis are not required around the condition in a if-statement in Go
- Let editor can auto completion the types. e.g. vim-go. - Add test cases for make sure they are correct.
Fix typo in doc
Change SuperAgent.Header type to http.Header for support multiple values
Add option to prevent SuperAgent from clearing
Add type constants
Added doc for DoNotClearSuperAgent
Add references to the issue being addressed and better comments and variablenames.
Don't infer Content-Type when set explicitly
updating some of the English
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add check timeout on retry