-
Notifications
You must be signed in to change notification settings - Fork 3
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix premature check on abstract class (#23)
`@abstractattrs` check shouldn't interpret an abstract class as concrete. We're now checking if a class is abstract before verifying abstract attributes. I'm aware that there's a discrepancy here. If there's no methods decorated as `@abstractmethod` and we only have ´@abstractattrs` we'll still need to inherit `abc.ABC` on each subclass. However, this change still covers some additional cases
- Loading branch information
Showing
3 changed files
with
21 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters