-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style edits #380
base: main
Are you sure you want to change the base?
style edits #380
Conversation
Reviewers, please correct any inaccuracies I might introduced inadvertently. Thank you.
Signed-off-by: angelinalg <[email protected]>
"As the request to generate the image runs, logs will be printed to the terminal that is running `serve run`." | ||
"As the request to generate the image runs, Anyscale prints logs to the terminal that's running `serve run`." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not really accurate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the process prints the logs to the terminal
"# Run the following in a VSCode terminal because it's a blocking command.\n", | ||
"# Run the following in a VS Code terminal because it's a blocking command.\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think it's typically stylized as VSCode
@@ -126,7 +126,7 @@ | |||
"1. Update the `HOST` to the service endpoint.\n", | |||
"2. Add the authorization token as a header in the HTTP request.\n", | |||
"\n", | |||
"Both of these values are printed when you run `anyscale service deploy`. You can also find them on the service page. For example, if the output looks like:\n", | |||
"Anyscale prints both of these values you run `anyscale service deploy`. You can also find them on the service page. For example, if the output looks like:\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
again not really anyscale, it's the CLI command that prints it
@@ -79,7 +79,7 @@ Query the service using the same logic as when testing it locally, with two chan | |||
1. Update the `HOST` to the service endpoint. | |||
2. Add the authorization token as a header in the HTTP request. | |||
|
|||
Both of these values are printed when you run `anyscale service deploy`. You can also find them on the service page. For example, if the output looks like: | |||
Anyscale prints both of these values you run `anyscale service deploy`. You can also find them on the service page. For example, if the output looks like: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
Reviewers, please correct any inaccuracies I might introduced inadvertently. Thank you.
Follow up from style edits reported in this PR: https://github.com/anyscale/docs/pull/1033/files#top