Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style edits #380

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

style edits #380

wants to merge 2 commits into from

Conversation

angelinalg
Copy link
Contributor

Reviewers, please correct any inaccuracies I might introduced inadvertently. Thank you.

Follow up from style edits reported in this PR: https://github.com/anyscale/docs/pull/1033/files#top

angelinalg and others added 2 commits October 9, 2024 17:54
Reviewers, please correct any inaccuracies I might introduced inadvertently. Thank you.
Signed-off-by: angelinalg <[email protected]>
@angelinalg angelinalg requested a review from edoakes October 10, 2024 16:29
"As the request to generate the image runs, logs will be printed to the terminal that is running `serve run`."
"As the request to generate the image runs, Anyscale prints logs to the terminal that's running `serve run`."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not really accurate

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the process prints the logs to the terminal

"# Run the following in a VSCode terminal because it's a blocking command.\n",
"# Run the following in a VS Code terminal because it's a blocking command.\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think it's typically stylized as VSCode

@@ -126,7 +126,7 @@
"1. Update the `HOST` to the service endpoint.\n",
"2. Add the authorization token as a header in the HTTP request.\n",
"\n",
"Both of these values are printed when you run `anyscale service deploy`. You can also find them on the service page. For example, if the output looks like:\n",
"Anyscale prints both of these values you run `anyscale service deploy`. You can also find them on the service page. For example, if the output looks like:\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again not really anyscale, it's the CLI command that prints it

@@ -79,7 +79,7 @@ Query the service using the same logic as when testing it locally, with two chan
1. Update the `HOST` to the service endpoint.
2. Add the authorization token as a header in the HTTP request.

Both of these values are printed when you run `anyscale service deploy`. You can also find them on the service page. For example, if the output looks like:
Anyscale prints both of these values you run `anyscale service deploy`. You can also find them on the service page. For example, if the output looks like:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants