-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AMQ-8463] Add advancedMessageStatistics feature #1329
Conversation
a25b984
to
dabeb33
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing I noticed is the new statistic impl classes all are copy and pasted code, it seems like you could just re-use all of that if you used generics.
I know this would be a much bigger effort but if we intend to keep adding more and more metrics, from a performance and maintainability standpoint, we should really look into moving everything to Micrometer which adds more more flexibility and should be better performance. That kind of change would likely end up being a major version, ie AMQ 7.0 if we wanted to do that. |
activemq-client/src/main/java/org/apache/activemq/management/UnsampledStatisticImpl.java
Outdated
Show resolved
Hide resolved
activemq-client/src/main/java/org/apache/activemq/management/StringStatisticImpl.java
Outdated
Show resolved
Hide resolved
activemq-client/src/main/java/org/apache/activemq/management/LongStatistic.java
Outdated
Show resolved
Hide resolved
activemq-client/src/main/java/org/apache/activemq/management/UnsampledStatisticImpl.java
Outdated
Show resolved
Hide resolved
activemq-broker/src/main/java/org/apache/activemq/broker/region/DestinationStatistics.java
Outdated
Show resolved
Hide resolved
df08462
to
c461626
Compare
Local performance testing showed no degradation in performance 64x producers sending in async to a single topic sent 1M messages ea in ~24s on a 2023 14" Apple M3 Pro (2.6M messages/sec) |
activemq-broker/src/main/java/org/apache/activemq/broker/jmx/DestinationView.java
Show resolved
Hide resolved
activemq-broker/src/main/java/org/apache/activemq/broker/region/DestinationStatistics.java
Outdated
Show resolved
Hide resolved
activemq-broker/src/main/java/org/apache/activemq/broker/region/DestinationStatistics.java
Outdated
Show resolved
Hide resolved
activemq-broker/src/main/java/org/apache/activemq/broker/region/Queue.java
Outdated
Show resolved
Hide resolved
activemq-client/src/main/java/org/apache/activemq/management/StatisticImpl.java
Outdated
Show resolved
Hide resolved
activemq-client/src/main/java/org/apache/activemq/management/StatsImpl.java
Outdated
Show resolved
Hide resolved
@mattrpav - I opened up a PR to this branch to fix a few things but I noted that I think StatisticImpl has some issues right now with the changes (mostly due to the fact that so many classes inherit from it) mattrpav#1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
made a few comments to look at but for the most part it LGTM
activemq-broker/src/main/java/org/apache/activemq/broker/region/DestinationStatistics.java
Outdated
Show resolved
Hide resolved
activemq-broker/src/main/java/org/apache/activemq/broker/region/DestinationStatistics.java
Outdated
Show resolved
Hide resolved
activemq-broker/src/main/java/org/apache/activemq/broker/region/DestinationStatistics.java
Outdated
Show resolved
Hide resolved
activemq-client/src/main/java/org/apache/activemq/management/StatisticImpl.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Christopher L. Shannon <[email protected]>
Reviewer notes: