-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow proxy protocol configuration for APISIX #528
feat: allow proxy protocol configuration for APISIX #528
Conversation
Hello! Some checks have failed due to a missing space in chart comments. |
Hello! Thanks for the CI trigger. I've updated the Apisix Helm Chart Readme accordingly with |
Hello! Is there any maintainer for the PR review? Thanks in advance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't find any more details on this proxy protocol
feature. Not sure if the current modification is appropriate. PTAL @tao12345666333
I will add this to my list and review it ASAP. Thanks |
Hello @tao12345666333, have you seen latest changes for this topic? Thank you in advance for your help. |
Other parts LGTM |
And please resolve the conflicts. |
@tao12345666333 said :
The conflicts are resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you for your contribution!
Hello everybody 👋
I'm currently trying to install APISIX on Kubernetes clusters that need to use Proxy Protocol in order to be usable. Unfortunately, the current Helm Chart does not allow to configure APISIX with proxy protocol by using
values.yaml
configuration.The previous PR #353 about this subject is getting old, and @hgranillo has moved from APISIX, so here is a new one, updated and ready to merge.
I tested this Chart update on our K8S clusters, without any problem.
As stated in the original PR :
Here is the
values.yaml
I used for tests :This PR also bumps Chart Version to the next minor :
1.4.0
.All comments are welcome.