Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add description parameter to ApisixConsumer #2223

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jorgenll
Copy link

Type of change:

  • New feature provided

What this PR does / why we need it:

Add support for define the AsipixConsumer description on the CRD and propagate this information to the Consumer synchronized on APISIX.
I need to define the description of the consumer but the CRD don't support it. I've try to use a label as alternative but the Kubernetes spec don't allow whitespaces on labels.

fixes #2222

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@jorgenll
Copy link
Author

jorgenll commented Apr 25, 2024

I've fix the e2e tests (I forgot the name conversion process...) and the lint problems.

I also review in my local environment the unit test and run successfully, but in the workflow the file cmd/ingress/ingress_test.go, test TestRotateLog, fails with connection refuse errors. Anyone can help my with this error?

Finally, I've a doubt: the release 1.8.1 was released on April 15th, but several files still use the 1.8.0 version (the Makefile for example) and the master branch diverge from this release (compare). I need to perform any change in my PR? Thanks!

@jorgenll
Copy link
Author

Hi! @pottekkat, could you execute again the workflow?
@Revolyssup, could you help me clarify the error with the unit-test?
Thanks all!!

@pottekkat
Copy link
Member

Trigged a rerun.

@jorgenll
Copy link
Author

Great, the workflow works fine and all is green. Thanks!!

@jorgenll
Copy link
Author

Hi @pottekkat, how should review the PR?

@pottekkat pottekkat requested a review from Revolyssup May 16, 2024 07:24
@jorgenll
Copy link
Author

jorgenll commented Jun 4, 2024

Hi @pottekkat , @Revolyssup, any update on this feature? Thanks!

@jorgenll
Copy link
Author

Hi @pottekkat, @Revolyssup, do you need anything to review the pull request? Thanks

@jorgenll
Copy link
Author

Hi @pottekkat , could you relaunch the workflow? Thanks!

@jorgenll jorgenll requested a review from Revolyssup July 4, 2024 11:08
@Revolyssup Revolyssup requested a review from AlinsRan July 4, 2024 16:36
@jorgenll
Copy link
Author

jorgenll commented Jul 8, 2024

Hi @AlinsRan, any feedback or comment on this pull request? Thanks!

@jorgenll
Copy link
Author

@AlinsRan, do you see any problem on the PR? We need this feature to complete a migration to APISIX.
Additionally, do you think that this feature could be included in the next release? When it's planned?
Thanks!!

Copy link

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 30 days if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the [email protected] list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Sep 29, 2024
@jorgenll
Copy link
Author

Hi. Any comment about the proposed change? @AlinsRan , @Revolyssup

@github-actions github-actions bot removed the stale label Sep 30, 2024
Copy link

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 30 days if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the [email protected] list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Nov 29, 2024
@jorgenll
Copy link
Author

Waiting for review

@github-actions github-actions bot removed the stale label Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: As a user, I want to add support for consumer description
3 participants