-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add description parameter to ApisixConsumer #2223
base: master
Are you sure you want to change the base?
Conversation
I've fix the e2e tests (I forgot the name conversion process...) and the lint problems. I also review in my local environment the unit test and run successfully, but in the workflow the file cmd/ingress/ingress_test.go, test TestRotateLog, fails with connection refuse errors. Anyone can help my with this error? Finally, I've a doubt: the release 1.8.1 was released on April 15th, but several files still use the 1.8.0 version (the Makefile for example) and the master branch diverge from this release (compare). I need to perform any change in my PR? Thanks! |
Hi! @pottekkat, could you execute again the workflow? |
Trigged a rerun. |
Great, the workflow works fine and all is green. Thanks!! |
Hi @pottekkat, how should review the PR? |
Hi @pottekkat , @Revolyssup, any update on this feature? Thanks! |
Hi @pottekkat, @Revolyssup, do you need anything to review the pull request? Thanks |
Hi @pottekkat , could you relaunch the workflow? Thanks! |
Hi @AlinsRan, any feedback or comment on this pull request? Thanks! |
@AlinsRan, do you see any problem on the PR? We need this feature to complete a migration to APISIX. |
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 30 days if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the [email protected] list. Thank you for your contributions. |
Hi. Any comment about the proposed change? @AlinsRan , @Revolyssup |
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 30 days if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the [email protected] list. Thank you for your contributions. |
Waiting for review |
Type of change:
What this PR does / why we need it:
Add support for define the AsipixConsumer description on the CRD and propagate this information to the Consumer synchronized on APISIX.
I need to define the description of the consumer but the CRD don't support it. I've try to use a label as alternative but the Kubernetes spec don't allow whitespaces on labels.
fixes #2222
Pre-submission checklist: