Skip to content

Commit

Permalink
restyle(cpp): rename logging level with "FURY_" prefix
Browse files Browse the repository at this point in the history
thus the duplicated micro problem could be solved.

Signed-off-by: Junduo Dong <[email protected]>
  • Loading branch information
An-DJ committed Jan 21, 2025
1 parent 4f2b88d commit e0715e2
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 17 deletions.
24 changes: 12 additions & 12 deletions cpp/fury/util/logging.cc
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,9 @@ std::string GetCallTrace() {
}

std::unordered_map<FuryLogLevel, std::string> log_level_to_str = {
{FuryLogLevel::DEBUG, "DEBUG"}, {FuryLogLevel::INFO, "INFO"},
{FuryLogLevel::WARNING, "WARNING"}, {FuryLogLevel::ERR, "ERROR"},
{FuryLogLevel::FATAL, "FATAL"},
{FuryLogLevel::FURY_DEBUG, "DEBUG"}, {FuryLogLevel::FURY_INFO, "INFO"},
{FuryLogLevel::FURY_WARNING, "WARNING"}, {FuryLogLevel::FURY_ERROR, "ERROR"},
{FuryLogLevel::FURY_FATAL, "FATAL"},
};

std::string LogLevelAsString(FuryLogLevel level) {
Expand All @@ -65,26 +65,26 @@ std::string LogLevelAsString(FuryLogLevel level) {
}

FuryLogLevel FuryLog::GetLogLevel() {
FuryLogLevel severity_threshold = FuryLogLevel::INFO;
FuryLogLevel severity_threshold = FuryLogLevel::FURY_INFO;
const char *var_value = std::getenv("FURY_LOG_LEVEL");
if (var_value != nullptr) {
std::string data = var_value;
std::transform(data.begin(), data.end(), data.begin(), ::tolower);
if (data == "debug") {
severity_threshold = FuryLogLevel::DEBUG;
severity_threshold = FuryLogLevel::FURY_DEBUG;
} else if (data == "info") {
severity_threshold = FuryLogLevel::INFO;
severity_threshold = FuryLogLevel::FURY_INFO;
} else if (data == "warning") {
severity_threshold = FuryLogLevel::WARNING;
severity_threshold = FuryLogLevel::FURY_WARNING;
} else if (data == "error") {
severity_threshold = FuryLogLevel::ERR;
severity_threshold = FuryLogLevel::FURY_ERROR;
} else if (data == "fatal") {
severity_threshold = FuryLogLevel::FATAL;
severity_threshold = FuryLogLevel::FURY_FATAL;
} else {
FURY_LOG_INTERNAL(WARNING)
FURY_LOG_INTERNAL(FURY_WARNING)
<< "Unrecognized setting of FuryLogLevel=" << var_value;
}
FURY_LOG_INTERNAL(INFO)
FURY_LOG_INTERNAL(FURY_INFO)
<< "Set ray log level from environment variable RAY_BACKEND_LOG_LEVEL"
<< " to " << static_cast<int>(severity_threshold);
}
Expand All @@ -99,7 +99,7 @@ FuryLog::FuryLog(const char *file_name, int line_number, FuryLogLevel severity)
}

FuryLog::~FuryLog() {
if (severity_ == FuryLogLevel::FATAL) {
if (severity_ == FuryLogLevel::FURY_FATAL) {
Stream() << "\n*** StackTrace Information ***\n" << ::fury::GetCallTrace();
Stream() << std::endl;
std::_Exit(EXIT_FAILURE);
Expand Down
10 changes: 5 additions & 5 deletions cpp/fury/util/logging.h
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,11 @@ std::string GetCallTrace();
// Simple logging implementation to avoid introduce glog dependency.

enum class FuryLogLevel {
DEBUG = -1,
INFO = 0,
WARNING = 1,
ERR = 2,
FATAL = 3
FURY_DEBUG = -1,
FURY_INFO = 0,
FURY_WARNING = 1,
FURY_ERROR = 2,
FURY_FATAL = 3
};

#define FURY_LOG_INTERNAL(level) \
Expand Down

0 comments on commit e0715e2

Please sign in to comment.