Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(cpp): rename logging level with "FURY_" prefix #2016

Merged
merged 4 commits into from
Jan 21, 2025

Conversation

An-DJ
Copy link
Contributor

@An-DJ An-DJ commented Jan 21, 2025

What does this PR do?

Thus the duplicated macro problem could be solved.

Related issues

Does this PR introduce any user-facing change?

  • Does this PR introduce any public API change?
  • Does this PR introduce any binary protocol compatibility change?

Benchmark

thus the duplicated micro problem could be solved.

Signed-off-by: Junduo Dong <[email protected]>
@An-DJ An-DJ changed the title restyle(cpp): rename logging level with "FURY_" prefix style(cpp): rename logging level with "FURY_" prefix Jan 21, 2025
@An-DJ An-DJ marked this pull request as draft January 21, 2025 02:36
An-DJ added 3 commits January 21, 2025 10:40
Signed-off-by: Junduo Dong <[email protected]>
Signed-off-by: Junduo Dong <[email protected]>
Signed-off-by: Junduo Dong <[email protected]>
@An-DJ An-DJ marked this pull request as ready for review January 21, 2025 03:43
Copy link
Collaborator

@chaokunyang chaokunyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chaokunyang chaokunyang merged commit 45d3001 into apache:main Jan 21, 2025
39 checks passed
@An-DJ An-DJ deleted the logging-level-rename branch January 21, 2025 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants