Skip to content
This repository has been archived by the owner on Oct 30, 2023. It is now read-only.

Fix bug in memory estimation #49

Closed
wants to merge 2 commits into from
Closed

Fix bug in memory estimation #49

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f5a124b
Fix bug in memory estimation
dlogothetis Sep 19, 2017
8e06d2b
Change log line
dlogothetis Sep 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion giraph-core/src/main/java/org/apache/giraph/ooc/policy/MemoryEstimatorOracle.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -792,7 +792,6 @@ private static boolean calculateRegression(double[] coefficient,
LOG.warn("There are " + coefficient.length +
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make this a LOG.info. We can also entirely remove this if block as it doesn't add much info to the log actually. If we want to keep the if, we should also remove the "but" from the logline :-)

" coefficients, but " + validColumnIndices.size() +
" valid columns in the regression");
return false;
}

double[] beta = mlr.estimateRegressionParameters();
Expand Down