#5440 fix(web): include missing JDBC properties in catalog creation payload for Apache Iceberg #5441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LauraXia123 would you please help to review this PR? |
|
@niyushabaghayi hi, the latest commit have no issue about #5440 , let me know if you have any problems after retesting! |
|
Thanks, @LauraXia123! Could you please point me to the specific issue and related PR that resolved this problem? I tried searching but couldn't find it, and I'm still experiencing the issue on the latest version (Gravitino 0.6.1-incubating). Any guidance would be greatly appreciated! |
|
Fixed on (Gravitino 0.7.0-incubating), you can retry it on main branch or tag (v0.7.0-incubating-rc2). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
These changes are needed to address a bug in the Gravitino UI that prevents users from successfully creating a catalog with
type: relationalandprovider: Apache Iceberg. The missing properties cause a 400 error on the backend, blocking catalog creation.Fix: #5440
Does this PR introduce any user-facing change?
Yes, this PR allows users to create catalogs with
type: relationalandprovider: Apache Icebergwithout encountering a 400 error due to missing JDBC properties. It resolves the issue of incomplete payloads and improves catalog creation reliability.How was this patch tested?
typetorelational,providertoApache Iceberg, and configuredcatalog-backendasjdbcwith appropriatejdbc-driver,jdbc-user, andjdbc-passwordvalues.Steps to Test:
Follow the reproduction steps outlined in the issue report to confirm that the changes address the problem.
Edge Cases:
Tested with
catalog-backendset tojdbcand verified correct behavior.