Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#6196] feat(iceberg): adjust table distribution if creating table without specifying disribution mode #6299

Conversation

github-actions[bot]
Copy link

What changes were proposed in this pull request?

Adjust the distribution mode for creating Iceberg table with none distribution. the following is the Spark adjust logic, the flink is similar.

  private DistributionMode defaultWriteDistributionMode() {
    if (table.sortOrder().isSorted()) {
      return RANGE;
    } else if (table.spec().isPartitioned()) {
      return HASH;
    } else {
      return NONE;
    }
  }

Why are the changes needed?

Fix: #6196

Does this PR introduce any user-facing change?

Yes, add document

How was this patch tested?

add UT and IT

…thout specifying disribution mode (#6214)

### What changes were proposed in this pull request?

Adjust the distribution mode for creating Iceberg table with none
distribution. the following is the Spark adjust logic, the flink is
similar.

```java
  private DistributionMode defaultWriteDistributionMode() {
    if (table.sortOrder().isSorted()) {
      return RANGE;
    } else if (table.spec().isPartitioned()) {
      return HASH;
    } else {
      return NONE;
    }
  }
```

### Why are the changes needed?

Fix: #6196 

### Does this PR introduce _any_ user-facing change?

Yes, add document

### How was this patch tested?

add UT and IT
@github-actions github-actions bot requested review from FANNG1 and jerryshao January 16, 2025 09:00
@FANNG1 FANNG1 closed this Jan 16, 2025
@FANNG1 FANNG1 reopened this Jan 16, 2025
@jerryshao jerryshao merged commit 54d1c2a into branch-0.8 Jan 16, 2025
28 checks passed
@jerryshao jerryshao deleted the cherry-pick-branch-0.8-e6225a01ea72d614c465a04262c78d2c8f337f49 branch January 16, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants