Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#6335] fix(python-client): Fix pypi document link error #6342

Merged
merged 3 commits into from
Jan 22, 2025
+2 −2
Merged

[#6335] fix(python-client): Fix pypi document link error #6342

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a69b37b
fix flink paimon document
FANNG1 Jan 21, 2025
0e06e22
fix flink paimon document
FANNG1 Jan 22, 2025
4c64803
fix flink paimon document
FANNG1 Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion clients/client-python/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ pythonPlugin {
pythonVersion.set(project.rootProject.extra["pythonVersion"].toString())
}

val gravitinoVersion: String = project.properties["version"] as String

fun deleteCacheDir(targetDir: String) {
project.fileTree(project.projectDir).matching {
include("**/$targetDir/**")
Expand Down Expand Up @@ -122,7 +124,7 @@ fun generatePypiProjectHomePage() {
// relative path of the images in the how-to-use-python-client.md file is incorrect. We need
// to fix the relative path of the images/markdown to the absolute path.
val content = outputFile.readText()
val docsUrl = "https://datastrato.ai/docs/latest"
val docsUrl = "https://gravitino.apache.org/docs/$gravitinoVersion"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change to

val docsUrl = "https://gravitino.apache.org/docs/latest"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If using latest, all release pypi document will link to the latest Gravitino document page, is it expected?


// Use regular expression to match the `[](./a/b/c.md?language=python)` or `[](./a/b/c.md#arg1)` link in the content
// Convert `[](./a/b/c.md?language=python)` to `[](https://datastrato.ai/docs/latest/a/b/c/language=python)`
Expand Down
Loading