HIVE-28677: Implement direct sql for delete table/partition column stats #5587
+128
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| public boolean deletePartitionColumnStats(String catName, String dbName, String tblName, | ||
| String partName, String colName, String engine) throws MetaException { | ||
| String sqlFilter = "" + PARTITIONS + ".\"PART_NAME\" = ? "; |
There was a problem hiding this comment.
Empty String can be removed from the value of sqlFilter?
| return new GetHelper<Boolean>(catName, dbName, tableName, true, true) { | ||
| @Override | ||
| protected String describeResult() { | ||
| return "delete prtition column stats"; |
There was a problem hiding this comment.
nit: partition spelling.
|
LGTM +1 (non-binding) |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Improve the performance of deleting column stats for wide table.
Why are the changes needed?
The JDO implementation of deleting column stats needs to retrieve the column stats objects, it could be slow if the table has many columns.
Does this PR introduce any user-facing change?
No.
Is the change a dependency upgrade?
No.
How was this patch tested?
Add some unit tests:
mvn test -Dtest.groups= -Dtest=org.apache.hadoop.hive.metastore.TestObjectStore#testPartitionStatisticsOps -pl :hive-standalone-metastore-server