Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @override #1312

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Conversation

cosmastech
Copy link
Contributor

@cosmastech cosmastech commented Nov 11, 2024

Resolves #1310

@cosmastech
Copy link
Contributor Author

@kevinjqliu Would you mind taking a look at what I've implemented thus far? It looks like this is failing in the pipeline, since typing.override doesn't exist prior to 3.13. Did I misunderstand what you had suggested?

@kevinjqliu
Copy link
Contributor

thanks for the PR! Looks like i was wrong and we need to do something like this in order to make the other python versions happy

#1310 (comment)

@cosmastech
Copy link
Contributor Author

thanks for the PR! Looks like i was wrong and we need to do something like this in order to make the other python versions happy

#1310 (comment)

Do you suggest making a utility file that holds this, or to add that import check to the top of each file? It looks like there are lots of files that will need @override added which is why I'm leaning towards a utility file for it

@kevinjqliu
Copy link
Contributor

what would the utility file look like? currently we use TYPE_CHECKING in a bunch of places already

https://grep.app/search?q=TYPE_CHECKING&filter[repo.pattern][0]=apache/iceberg-python

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add @typing.override to functions
2 participants