-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add @override #1312
base: main
Are you sure you want to change the base?
Add @override #1312
Conversation
@kevinjqliu Would you mind taking a look at what I've implemented thus far? It looks like this is failing in the pipeline, since typing.override doesn't exist prior to 3.13. Did I misunderstand what you had suggested? |
thanks for the PR! Looks like i was wrong and we need to do something like this in order to make the other python versions happy |
Do you suggest making a utility file that holds this, or to add that import check to the top of each file? It looks like there are lots of files that will need |
what would the utility file look like? currently we use https://grep.app/search?q=TYPE_CHECKING&filter[repo.pattern][0]=apache/iceberg-python |
Resolves #1310