-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
automate building Release Candidate in github action #1391
Open
kevinjqliu
wants to merge
29
commits into
apache:main
Choose a base branch
from
kevinjqliu:kevinjqliu/run-pypi-and-svn
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinjqliu
force-pushed
the
kevinjqliu/run-pypi-and-svn
branch
from
December 4, 2024 06:46
b26c2a7
to
b22117b
Compare
@Fokko could you take a look at this PR when you get a chance? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1306 and #872
Devlist discussion: https://lists.apache.org/thread/oowhcfwv3fcjzdzm76tbn99k5q84mr75
This PR changes
.github/workflows/python-release.yml
to build the artifacts for both svn and pypi and update the "how to release doc" to match the new process. Other improvements related to the release process are also included:version
andrc
version
andrc
from either tag or manual inputversion
against the current library versionactions/checkout@v4
fetch-depth
from0
to1
to fetch only a single commit (fetch-depth 0 fetches all history for all branches and tags)svn-release-candidate-${VERSION}rc${RC}
pypi-release-candidate-${VERSION}rc${RC}
, set library version to one with RC (e.g. 0.8.1rc1, same behavior as before)Final release process should look something like this
main
for major/minor,branch
for patch release)0.8.1rc1
)0.8.1rc2
)Testing
version=0.8.0
,rc=10
, https://github.com/kevinjqliu/iceberg-python/actions/runs/12166623947) ✅version=0.8.a
,rc=10
, https://github.com/kevinjqliu/iceberg-python/actions/runs/12167579948) ✅version=0.8.0
,rc=a
, https://github.com/kevinjqliu/iceberg-python/actions/runs/12167639523/job/33936658282) ✅version=1.0.0
,rc=100
, https://github.com/kevinjqliu/iceberg-python/actions/runs/12167654762) ✅tag=pyiceberg-0.8.0rc10
, https://github.com/kevinjqliu/iceberg-python/actions/runs/12167691265) ✅tag=pyiceberg-0.8.arc10
, not triggered ✅ )tag=pyiceberg-0.8.0rca
, not triggered ✅ )tag=pyiceberg-1.0.0rc100
, https://github.com/kevinjqliu/iceberg-python/actions/runs/12168199006 ✅)